Skip to content

Cleaning up params lists #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 29, 2022
Merged

Cleaning up params lists #66

merged 3 commits into from
Jul 29, 2022

Conversation

holtbp
Copy link
Contributor

@holtbp holtbp commented Jul 29, 2022 •
edited by pcothenet
Loading

What

  • Correct auto-generation of the SDK

Why

  • Make sure it can be re-generated on demand

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the library locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • If endpoints were removed, did you manually remove the corresponding files? (this should be rare)
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@pcothenet pcothenet closed this Jul 29, 2022
@holtbp holtbp reopened this Jul 29, 2022
@pcothenet pcothenet marked this pull request as ready for review July 29, 2022 02:24
@pcothenet pcothenet self-requested a review July 29, 2022 02:24
@holtbp holtbp changed the title This is what it should look like Cleaning up params lists Jul 29, 2022
@holtbp holtbp merged commit ffc43b9 into main Jul 29, 2022
@holtbp holtbp deleted the bh-cleanup branch July 29, 2022 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcothenet pcothenet pcothenet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holtbp @pcothenet