Skip to content

Updates after post-mortem #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 22, 2020
Merged

Updates after post-mortem #12

merged 3 commits into from
Sep 22, 2020

Conversation

biglovisa
Copy link
Contributor

  • Added support for building the ruby gem before running tests
  • Added support for running the specs before releasing the gem
  • Added a PR template to remind authors of adding tests and building the gem locally and running queries against it successfully

@biglovisa biglovisa requested a review from thdaraujo September 21, 2020 22:53
thdaraujo
thdaraujo approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@biglovisa biglovisa merged commit ae05ff9 into main Sep 22, 2020
@biglovisa biglovisa deleted the lovisa/post-mortem-updates branch September 22, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thdaraujo thdaraujo thdaraujo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biglovisa @thdaraujo