Skip to content

Fix Healthcheck #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2021
Merged

Fix Healthcheck #30

merged 1 commit into from
Apr 2, 2021

Conversation

biglovisa
Copy link
Contributor

What

  • The healthchecks haven't been running since the syntax have been wrong

Why

  • So that the healthchecks run

SDK Release Checklist

N/A

  • Have you added an integration test for the changes?
  • Have you built the gem locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

biglovisa
biglovisa commented Apr 2, 2021
View reviewed changes
.github/workflows/health_check.yml
@@ -19,13 +19,12 @@ jobs:
- name: Install Ruby Dependencies
run: bundle install

- name: Build Gem
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to build the gem since we are just interested in running the tests.

@biglovisa biglovisa self-assigned this Apr 2, 2021
@biglovisa biglovisa added the Needs Review The PR is ready to be reviewed label Apr 2, 2021
@biglovisa biglovisa requested a review from pcothenet April 2, 2021 00:40
@biglovisa biglovisa merged commit 050daf5 into main Apr 2, 2021
@biglovisa biglovisa deleted the lovisa/healthcheck branch April 2, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcothenet pcothenet pcothenet approved these changes

Assignees

@biglovisa biglovisa

Labels
Needs Review The PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biglovisa @pcothenet