Add ETH estimates #33
Conversation
| end | ||
|
|
||
| # Create an ethereum estimate given a timestamp and gas used | ||
| # Creates an ethereum estimate for the amount of CO2 to be compensated. An order in the `draft` state may be created based on the parameters, linked to the estimate. |
There was a problem hiding this comment.
assuming this is an html encoding bug with openapi but there are ` chars in this comment
There was a problem hiding this comment.
Good catch. Let me check the swagger file to see if the issue is there or is due to code generation.
| @@ -99,4 +99,37 @@ | |||
| expect(bitcoin_estimate.data.type).to eq 'bitcoin' | |||
| expect(bitcoin_estimate.data.mass_g).to be < bitcoin_estimate_2.data.mass_g | |||
| end | |||
|
|
|||
| it 'supports creating bitcoin estimates with a timestamp' do | |||
There was a problem hiding this comment.
the sdk code is autogenerated but I'm assuming the tests are written manually. Can you please confirm?
There was a problem hiding this comment.
it would be nice to wrap each group of it for a method being tested in a describe block. On a second take, I realized this test was for the bitcoin method and not the ethereum method
There was a problem hiding this comment.
Yes. Code is auto-generated, tests are manual.
Good call on the grouping, I'll update this PR.
| end | ||
|
|
||
| it 'supports creating ethereum estimates with partial information' do | ||
| ethereum_estimate = Patch::Estimate.create_ethereum_estimate({ create_order: false }) |
There was a problem hiding this comment.
the hash curly braces {} here are redundant
|
|
||
| expect(ethereum_estimate.data.type).to eq 'ethereum' | ||
| expect(ethereum_estimate.data.mass_g).to be >= 2_000 | ||
| end |
There was a problem hiding this comment.
seems there are tests for the use of create_order and gas_used params. Should there be tests for project_id and timestamp as well?
There was a problem hiding this comment.
In theory yes, let me add a few more.
What
Why
SDK Release Checklist