Skip to content

Adds deployment notifications #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2021
Merged

Adds deployment notifications #40

merged 2 commits into from
Sep 1, 2021

Conversation

pcothenet
Copy link
Contributor

What

  • Creates a GitHub deployment when the publish workflow is initiated
  • Updates the status of the deployment at the end of the workflow
  • This will trigger Slack notifications based on the Slack<>GitHub settings

Why

  • Rely on GitHub<>Slack instead of rolling our own custom notifications. This lets us have different settings for different channels / users/
  • Mirror how we notify of other applications

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the gem locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

Copy link
Contributor

@kleinjm kleinjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pcothenet pcothenet merged commit 225cff6 into main Sep 1, 2021
@pcothenet pcothenet deleted the pc/deploy branch September 1, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants