Skip to content

Add technology_type index method #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 4, 2021
Merged

Add technology_type index method #48

merged 3 commits into from
Oct 4, 2021

Conversation

kleinjm
Copy link
Contributor

@kleinjm kleinjm commented Oct 4, 2021

What

  • Add a technology type and method to fetch all types

Why

  • Support the new API in our SDKs

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the gem locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version in the code generator?
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@kleinjm kleinjm changed the title Add technology_type index call Add technology_type index method Oct 4, 2021
@kleinjm kleinjm marked this pull request as ready for review October 4, 2021 21:51
@kleinjm kleinjm requested a review from pcothenet October 4, 2021 21:51
pcothenet
pcothenet reviewed Oct 4, 2021
View reviewed changes
spec/models/project_spec.rb
Set.new(%i[photos standard sdgs state latitude longitude tagline])
Set.new(%i[photos standard sdgs state latitude longitude])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type of unrelated change is why it would be nice to have those PRs auto-generated one day :D

@kleinjm kleinjm merged commit 4cc8d07 into main Oct 4, 2021
@kleinjm kleinjm deleted the jklein/tech_type_api branch October 4, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcothenet pcothenet pcothenet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kleinjm @pcothenet