1.21.0 - API Completness #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 3, 2022 18:30
pcothenet
reviewed
May 4, 2022
Comment on lines
+10
to
+21
| ### Added | ||
|
|
||
| - Adds optional `total_price` and `currency` field to `order` creation | ||
| - Adds optional `amount` and `unit` field to `order` creation | ||
| - Adds inventory to `project` responses | ||
| - Adds inventory to `order` responses | ||
|
|
||
| ### Changed | ||
|
|
||
| - Deprecates `mass_g` and `total_price_cents_usd` fields for create `order` requests | ||
| - Deprecates `average_price_per_tonne_cents_usd` and `remaining_mass_g` from `project` responses | ||
| - Deprecates `price_cents_usd`, `patch_fee_cents_usd`, and `mass_g` from `order` responses |
pcothenet
reviewed
May 4, 2022
spec/integration/orders_spec.rb
Outdated
Comment on lines
143
to
148
| expect( | ||
| create_order_response.data.price + create_order_response.data.patch_fee | ||
| ).to be >= 99 | ||
| expect( | ||
| create_order_response.data.price + create_order_response.data.patch_fee | ||
| ).to be <= 101 |
There was a problem hiding this comment.
Could probably use within to make this one shorter.
pcothenet
approved these changes
May 4, 2022
added 2 commits
May 4, 2022 01:36
rmody3
force-pushed
the
rm/1.21.0
branch
2 times, most recently
from
06323e8 to
82f5b70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Asana: https://app.asana.com/0/1202119733323437/1202220351403228/f
Why
SDK Release Checklist