Skip to content

Attempt repair content on failed content installation #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2020

Conversation

genail
Copy link
Contributor

@genail genail commented Mar 22, 2020

Until now, when there was a CRC error while attempting to install
content, this error was non-recoverable.
Right now, we're allowing patcher to continue and attempting to fix
those files after unpacking is done.

Also, repairing process now checks if the files are okay after the
repair and tries again if not.

Checklist

  1. PR associated with Redmine issue (if applicable)
  2. Changelog entry with id of Redmine issue
  3. Created TODO for applying this change into 4.x.x line (if applicable)
  4. Version.cs up to date
  5. Review requested

Until now, when there was a CRC error while attempting to install
content, this error was non-recoverable.
Right now, we're allowing patcher to continue and attempting to fix
those files after unpacking is done.

Also, repairing process now checks if the files are okay after the
repair and tries again if not.
@genail genail requested a review from witcher112 March 22, 2020 12:09
Copy link
Contributor

@witcher112 witcher112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor adjustments required, beside that looks great.

@witcher112 witcher112 changed the base branch from master to dev/v3.17.x.x March 25, 2020 11:22
@witcher112 witcher112 merged commit 63f6e2f into dev/v3.17.x.x Mar 25, 2020
@witcher112 witcher112 deleted the dev/crc-repair branch March 25, 2020 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants