Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4l2: accommodate to struct filed rename of vb2_buffer::min_buffers_needed #292

Merged

Conversation

vicamo
Copy link
Contributor

@vicamo vicamo commented Feb 17, 2024

Failed to build against v6.8-rc4 due to upstream kernel commit 80c2b40a5139 ("media: videobuf2: core: Rename min_buffers_needed field in vb2_queue"):

/var/lib/dkms/facetimehd/0.5.18/build/fthd_v4l2.c: In function ‘fthd_v4l2_register’:
/var/lib/dkms/facetimehd/0.5.18/build/fthd_v4l2.c:687:10: error: ‘struct vb2_queue’ has no member named ‘min_buffers_needed’
  687 |         q->min_buffers_needed = 1;
      |          ^~
make[2]: *** [scripts/Makefile.build:243: /var/lib/dkms/facetimehd/0.5.18/build/fthd_v4l2.o] Error 1

…eeded

Signed-off-by: You-Sheng Yang <vicamo@gmail.com>
@paralin
Copy link

paralin commented Mar 20, 2024

@patjak this fixes kernel 6.8.x 👍🏽

@patjak patjak merged commit b1f7424 into patjak:master Mar 22, 2024
@patjak
Copy link
Owner

patjak commented Mar 22, 2024

Thanks for the fix!

@mulderje
Copy link

Thank you for the fix! Is it possible to cut a dot release with this included?

@patjak
Copy link
Owner

patjak commented Apr 3, 2024

Sure, here's the new release https://github.com/patjak/facetimehd/releases/tag/0.6.8.1

@mulderje
Copy link

mulderje commented Apr 8, 2024

Many thanks! Attempting to package up for fedora here: https://github.com/mulderje/facetimehd-kmod-rpm.

Please let me know if you have any interest in me pushing the spec files upstream once they are working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants