Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax the axiomatisation of prominence #297

Closed
matentzn opened this issue Feb 13, 2020 · 2 comments · Fixed by #319
Closed

Relax the axiomatisation of prominence #297

matentzn opened this issue Feb 13, 2020 · 2 comments · Fixed by #319

Comments

@matentzn
Copy link
Contributor

matentzn commented Feb 13, 2020

Currently we have this:

image

This causes some confusion as phenotypes with an abnormal prominence of something classify under abnormal position. I vote to simply move the prominence and protruding branches out from under position.

@dosumis @wdahdul @balhoff @sbello

@nicolevasilevsky
Copy link
Contributor

what do you think the parent should be then? should it be a child of 'physical quality'?

I'll create a PR for this and tag the folks above.

@dosumis
Copy link
Contributor

dosumis commented May 12, 2020

I'd keep superclass protruding, and move that under physical quality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants