Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugintabs): enabling multiple file formats #1163

Closed
mfranzke opened this issue Apr 28, 2020 · 1 comment · Fixed by #1166
Closed

fix(plugintabs): enabling multiple file formats #1163

mfranzke opened this issue Apr 28, 2020 · 1 comment · Fixed by #1166
Labels

Comments

@mfranzke
Copy link
Contributor

mfranzke commented Apr 28, 2020

@bmuenzenmeyer your overwrite with commit b82bd12 of the placeholders <<type>> and <<typeUC>> (to hardcoded scss) that are used within the script https://github.com/pattern-lab/patternlab-node/blob/dev/packages/plugin-tab/index.js now results in that only one file (and only scss filetype/language) could get configured within the patternlab-config.json.

It looks to me like that this happened by accident - I would than like to offer to fix this (and some other small parts) for this to work correctly again, if the change didn't happen on purpose.

@bmuenzenmeyer
Copy link
Member

yes this looks like a bug to me - though only that portion. the intent of that commit was still to check for window.patternlab && window.patternlab.panels

@mfranzke mfranzke changed the title question on a potential bug: plugin-tabs fix(plugin-tabs): enabling multiple file formats Apr 28, 2020
@mfranzke mfranzke changed the title fix(plugin-tabs): enabling multiple file formats fix(plugintabs): enabling multiple file formats Apr 28, 2020
mfranzke pushed a commit to mfranzke/patternlab-node that referenced this issue Apr 28, 2020
mfranzke pushed a commit to mfranzke/patternlab-node that referenced this issue Apr 28, 2020
bmuenzenmeyer added a commit that referenced this issue May 1, 2020
…le-file-formats

Fix plugin-tabs enabling multiple file formats #1163
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this issue Apr 12, 2023
…ling-multiple-file-formats

Fix plugin-tabs enabling multiple file formats pattern-lab#1163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants