Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: UIKit - referencing 'html-webpack-plugin' from NPM #1106

Merged
merged 1 commit into from
Nov 27, 2019
Merged

chore: UIKit - referencing 'html-webpack-plugin' from NPM #1106

merged 1 commit into from
Nov 27, 2019

Conversation

mfranzke
Copy link
Contributor

@mfranzke mfranzke commented Nov 27, 2019

As github might be inaccessible / blocked on some environments (for whatever/security reasons), it's probably better to reference this dependency from NPM instead of Github as well, and solve the problem of referencing to the beta version by its exact upper version number.

Closes #

Summary of changes:
"html-webpack-plugin" dependency is being retrieved via NPM instead of Github.

as github might be inaccessible / blocked on some environments (for whatever/security reasons), it's probably better to reference this dependency from NPM instead of Github as well, and solve the problem of referencing to the beta version by its exact upper version number.
@mfranzke mfranzke changed the title chore: referencing this dependency from NPM chore: referencing 'html-webpack-plugin' from NPM Nov 27, 2019
@mfranzke mfranzke changed the title chore: referencing 'html-webpack-plugin' from NPM chore: UIKit- referencing 'html-webpack-plugin' from NPM Nov 27, 2019
@mfranzke mfranzke changed the title chore: UIKit- referencing 'html-webpack-plugin' from NPM chore: UIKit - referencing 'html-webpack-plugin' from NPM Nov 27, 2019
@bmuenzenmeyer
Copy link
Member

great point @mfranzke !

@sghoweri was there any particular reason we targeted the git url previously? The github changelog and releases vs npm results are a bit confusing

image

@sghoweri
Copy link
Contributor

great point @mfranzke !

@sghoweri was there any particular reason we targeted the git url previously? The github changelog and releases vs npm results are a bit confusing

image

@bmuenzenmeyer if I’m remembering this correctly, the original reason for pointing to that Github repo branch (vs NPM) had to do with major Webpack v4-related issues that the available NPM versions published suffered from but the Github branch had already fixed.

It looks as if there’s been an uptick in recent activity + new betas published so this workaround might not be needed anymore!

Let me double check that this still works with some of the performance related logic in the Webpack build (ex. generating Critical CSS); would love to swap back to the NPM version (and even perhaps move this to being a devDependency).

Thanks guys!

Copy link
Contributor

@sghoweri sghoweri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming that this looks good to go on my end (everything compiling as expected — that includes additional Webpack plugins that hook into this HTML plugin like Critical CSS).

Thanks guys!

@sghoweri sghoweri merged commit 1514d97 into pattern-lab:dev Nov 27, 2019
@sghoweri sghoweri modified the milestones: v5.4.1, v5.4.2 Nov 27, 2019
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this pull request Apr 12, 2023
chore: UIKit - referencing 'html-webpack-plugin' from NPM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants