Fix failure to reset variables in loop #86
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating `patternLabHead` and `patternLabFoot` for `patternType` partials, the variables that hold the rendered strings were named incorrectly, which caused the header and footer to contain the rendered strings of the last rendered `patternSubType` (due to data hanging around from the last loop), or nothing if it was the first `patternType`.
|
This was fixed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating
patternLabHeadandpatternLabFootforpatternTypepartials, the variables that hold the rendered strings were named incorrectly,
which caused the header and footer to contain the rendered strings of the last
rendered
patternSubType(due to data hanging around from the last loop), ornothing if it was the first
patternType.This cause two bugs for us. 1) The styleguide.min.css was missing on our Atoms > View All, and 2) Clicking on Molecules > View All would actually load Atoms > Images instead.