Add ability to set a class or hide menu actions in List View #324
Conversation
|
Looks good. Any unit test coverage for these new options? |
jeff-phillips-18
force-pushed
the
list-view
branch
from
df5efc6 to
c8c55e2
Compare
|
@dtaylor113 Added unit tests for these options |
| @@ -238,6 +242,18 @@ | |||
| }, | |||
| ]; | |||
|
|
|||
| $scope.getMenuClass = function (item) { | |||
| var menuClass = ""; | |||
| if (item.name === "Jim Beam") { | |||
There was a problem hiding this comment.
Maybe a slightly less risque name here? Not sure if we have public standards for documentation or if I'm just being overly cautious...
There was a problem hiding this comment.
If we use it all over the place, let's leave it - I wasn't sure if the reference would be noticed by some given the connotation.
There was a problem hiding this comment.
I've changed the name to protect the innocent 👮
|
Heh, that name has been used here since its inception. Do you think I should change it? |
jeff-phillips-18
force-pushed
the
list-view
branch
from
c8c55e2 to
67cc414
Compare
|
I'm good with this. |
|
Thanks for this PR @jeff-phillips-18 |
|
Quick question: To be able to test these changes with SSUI, do I have to wait for the next version of angular-patternfly ? Currently SSUI uses |
|
Yes, angular patternfly should release 3.12.0 either today or very shortly and this PR looks to be included. |
This addresses issue #306
@dgutride @dtaylor113 @AparnaKarve