pfSelect - destroy the selectpicker when the directive is destroyed #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since patternfly 3.8, the structure of the HTML generated by the selectpicker has changed, and removing the original select element no longer necessarily removes the selectpicker div that's actually visible. This makes pf-select explicitly destroy the selectpicker when the element with that pf-select is going away. (Related to ManageIQ/manageiq#11893)
|
Ping @jeff-phillips-18 ;) |
|
Looks good |
|
Thanks everybody! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since patternfly 3.8, the structure of the HTML generated by the selectpicker js component has changed, and removing the original select element no longer necessarily removes the selectpicker div that's actually visible.
(Previously, the
selectwould just get a class to hide it, and thedivwould appear right after it (as a sibling), whereas now, the newdiveats up theselectand moves it inside itself.)This PR makes
pf-selectexplicitly destroy the selectpicker when the element with thatpf-selectis going away.Code like:
always works, but when the if is on the select:
then making the condition true and then false causes the selectpicker to stay on the page without this PR.