Skip to content

Improve list item documentation when using expanding content. #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2016
Merged

Improve list item documentation when using expanding content. #339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/views/listview/list-view-directive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* Pass a customScope object containing any scope variables/functions you need to access from the transcluded source, access these
* via 'customScope' in your transcluded hmtl.
* <br><br>
* If using expanding rows, use a list-expanded-content element containing expandable content for each row. For each item in the items array, the expansion can be disabled by setting disableRowExpansion to true on the item.
* If using expanding rows, use a list-expanded-content element containing expandable content for each row. Item data can be accessed inside list-expanded-content by using $parent.item.property. For each item in the items array, the expansion can be disabled by setting disableRowExpansion to true on the item.
*
* @param {array} items Array of items to display in the list view. If an item in the array has a 'rowClass' field, the value of this field will be used as a class specified on the row (list-group-item).
* @param {object} config Configuration settings for the list view:
Expand Down Expand Up @@ -79,17 +79,16 @@
</div>
</div>
<list-expanded-content>
{{item.city}}
<div class="row">
<div class="col-md-3">
<div pf-donut-pct-chart config="exampleChartConfig" data="{'used': '350','total': '1000'}" center-label="'Percent Used'"></div>
</div>
<div class="col-md-9">
<dl class="dl-horizontal">
<dt>Host Name</dt>
<dd>Hostceph1</dd>
<dt>Device Path</dt>
<dd>/dev/disk/pci-0000.05:00-sas-0.2-part1</dd>
<dt>Host</dt>
<dd>{{$parent.item.city}}</dd>
<dt>Admin</dt>
<dd>{{$parent.item.name}}</dd>
<dt>Time</dt>
<dd>January 15, 2016 10:45:11 AM</dd>
<dt>Severity</dt>
Expand Down