Refactor unit tests to support breaking changes in UI Router 1.0 #355
Conversation
| @@ -46,6 +46,6 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "angular-mocks": "1.3.0 - 1.5.*", | |||
| "angular-ui-router": "^0.3.2" | |||
| "angular-ui-router": "1.0.0-beta.3" | |||
There was a problem hiding this comment.
I don't think we want to update the devDependencies to the beta version. Is this necessary?
There was a problem hiding this comment.
Well, first of all we have to keep in mind that angular-ui-router is there only for the unit tests to run properly, since it's an optional runtime dependency. Given this, I updated it so we are sure that the refactored unit tests are passing properly since the refactor was indeed needed because of the breaking changes in 1.0.0.
In other words, 0.3.2 is perfectly fine and tests will pass with both version. Anyway I thought that testing against the newer version was safer. If you want me to remove it I'll do immediately 😄
There was a problem hiding this comment.
idk. It is a dev dependency, which to me seems like it could be cutting edge since it shouldn't effect production code. Just my 2 cents 😄
There was a problem hiding this comment.
Moreover, I think that 1.0.0-beta should be api-compatible with what will be 1.0.0 release.
This is to make Angular UI router unit tests pass when using UI Router 1.0 (tested with 1.0.0-beta4). The directive itself was already good, only the unit tests needed a minor refactor.