Fix filter dropdowns for pf card directives #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove intermediate `div` used to `ng-include` the card filter partial. The angular-ui-bootstrap dropdown directives require the `uib-dropdown` directive to be a direct parent of the toggle and menu directives. This change conditionally loads the card filter template without splitting the `uib` dropdown directives. Issue was raised here: patternfly#353
jeff-phillips-18
approved these changes
Dec 9, 2016
dgutride
approved these changes
Dec 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove intermediate
divused tong-includethe card filter partial.The angular-ui-bootstrap dropdown directives require the
uib-dropdowndirective to be a direct parent of the toggle and menu directives. This
change conditionally loads the card filter template without splitting
the
uibdropdown directives.Issue raised in #353