Remove JQuery Dependency from Angular Patternfly 4 #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the hyphenated version of the require specifications does not work in a non-jquery environment.
These directives are dependent on jQuery and can be replaced using angular ui bootstrap components.
jeff-phillips-18
force-pushed
the
branch-4.0-dev
branch
from
d58631e to
b89e582
Compare
dgutride
approved these changes
Dec 7, 2016
|
Hi, I noticed in HeatMap when you hover over a box, you do not see any tooltips. I thought we had them at some point. I don't see it working in the A-PF3 ngdocs, so I don't think this PR caused this. |
|
Cloned this branch, all unit tests pass, ran through most ngdoc examples -everything looks good! |
dtaylor113
approved these changes
Dec 7, 2016
|
Small nit, but I just noticed in the vertical nav. ngdoc examples, the Help and Username top right dropdowns in the masthead do not open :-( |
|
I noticed that as well but since its not really part of vertical nav I didn't take the time to work on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the JQuery dependency from the angular patternfly. Three of the existing directives have been removed:
pfSelect - this can be replace with Angular UI Boostrap's uibDropdown
pfDatepicker - this can be replaced with Angular UI Bootstrap's uibDatepicker
pfDateTimepicker - currently there is no non-jquery support for this component
The angular patternfly code has been adjusted to use the non-JQuery patternfly settings. To keep JQuery independence, include only patternfly-settings.js rather than patternfly.js.
@dtaylor113 @dgutride @dlabrecq @bleathem