New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JQuery Dependency from Angular Patternfly 4 #361

Merged
merged 6 commits into from Dec 7, 2016

Conversation

Projects
None yet
3 participants
@jeff-phillips-18
Copy link
Member

jeff-phillips-18 commented Dec 7, 2016

Description

This PR removes the JQuery dependency from the angular patternfly. Three of the existing directives have been removed:

pfSelect - this can be replace with Angular UI Boostrap's uibDropdown
pfDatepicker - this can be replaced with Angular UI Bootstrap's uibDatepicker
pfDateTimepicker - currently there is no non-jquery support for this component

The angular patternfly code has been adjusted to use the non-JQuery patternfly settings. To keep JQuery independence, include only patternfly-settings.js rather than patternfly.js.

@dtaylor113 @dgutride @dlabrecq @bleathem

jeff-phillips-18 added some commits Nov 3, 2016

Change wizard directive requires settings to be standard
Using the hyphenated version of the require specifications does not
work in a non-jquery environment.
Remove pfSelect, pfDatepicker, and pfDatetimepicker
These directives are dependent on jQuery and can be replaced using
angular ui bootstrap components.

@jeff-phillips-18 jeff-phillips-18 force-pushed the jeff-phillips-18:branch-4.0-dev branch from d58631e to b89e582 Dec 7, 2016

@dtaylor113

This comment has been minimized.

Copy link
Member

dtaylor113 commented Dec 7, 2016

Hi, I noticed in HeatMap when you hover over a box, you do not see any tooltips. I thought we had them at some point. I don't see it working in the A-PF3 ngdocs, so I don't think this PR caused this.

@dtaylor113

This comment has been minimized.

Copy link
Member

dtaylor113 commented Dec 7, 2016

Cloned this branch, all unit tests pass, ran through most ngdoc examples -everything looks good!

@dtaylor113 dtaylor113 merged commit bf18e02 into patternfly:branch-4.0-dev Dec 7, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dtaylor113

This comment has been minimized.

Copy link
Member

dtaylor113 commented Dec 7, 2016

Small nit, but I just noticed in the vertical nav. ngdoc examples, the Help and Username top right dropdowns in the masthead do not open :-(

@jeff-phillips-18

This comment has been minimized.

Copy link
Member

jeff-phillips-18 commented Dec 7, 2016

I noticed that as well but since its not really part of vertical nav I didn't take the time to work on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment