Skip to content

Conversation

dgutride
Copy link
Member

Card and list view directives converted to component syntax

  • Unit tests modified and pass with no behavioral changes
  • Existing attributes defining the properties were not changed
  • Test pages updated as well

@dtaylor113
Copy link
Member

LGTM. Just noticed that 'List View' in pfToolbar no longer works:

image

Card View still works thought.

@dtaylor113
Copy link
Member

Also noticed in List View, when I select 'row selection':

image

Then double-click on a row, I get an exception in the console:

- angular.js:14110 ReferenceError: scope is not defined
-    at ctrl.itemClick (angular-patternfly.js:8650)
-    at fn (eval at <anonymous> (angular.js:15033), <anonymous>:4:470)
-    at expensiveCheckFn (angular.js:16123)
-    at callback (angular.js:26490)
-    at Scope.$eval (angular.js:17913)
-    at Scope.$apply (angular.js:18013)
-    at HTMLDivElement.<anonymous> (angular.js:26495)
-    at defaultHandlerWrapper (angular.js:3540)
-    at HTMLDivElement.eventHandler (angular.js:3528)

@dgutride
Copy link
Member Author

@dtaylor113 - good catches, thanks for testing this - both of those have been fixed.

Copy link
Member

@dlabrecq dlabrecq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built the changes and tested the toolbar. LGTM.

@dlabrecq dlabrecq merged commit 9f9789d into patternfly:branch-4.0-dev Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants