Skip to content

Fix pfDatepicker to clear date and allow incomplete input dates #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 16, 2017
Merged

Fix pfDatepicker to clear date and allow incomplete input dates #388

merged 2 commits into from
Jan 16, 2017

Conversation

vkrizan
Copy link
Contributor

@vkrizan vkrizan commented Jan 14, 2017

Changelog:

  • Added listener clearDate to clear angular model on date/input clear.
  • Added condition in $watch to update datepicker date value only when dates are diffrent, to avoid resetting input value on incomplete or wrongly typed date.

Closes #313.

jeff-phillips-18
jeff-phillips-18 approved these changes Jan 16, 2017
View reviewed changes
Copy link
Member

@jeff-phillips-18 jeff-phillips-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jeff-phillips-18 jeff-phillips-18 merged commit 9498448 into patternfly:master Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-phillips-18 jeff-phillips-18 jeff-phillips-18 approved these changes

+1 more reviewer

@dtaylor113 dtaylor113 dtaylor113 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vkrizan @jeff-phillips-18 @dtaylor113