Hides selected filter results unless selected&totalCount !== undefined #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless selectedcount and total count are explicitly defined, will not display the "x of x selected" filter results text. Prevents unwanted text for instance, when there is no items to select
dtaylor113
reviewed
Jun 6, 2017
| @@ -12,7 +12,7 @@ | |||
| </li> | |||
| </ul> | |||
| <p><a class="clear-filters" ng-click="$ctrl.clearAllFilters()" ng-if="$ctrl.config.appliedFilters.length > 0">Clear All Filters</a></p> | |||
| <div ng-if="$ctrl.config.totalCount !== 0" class="pf-table-view-selected-label"> | |||
| <div ng-if="$ctrl.config.selectedCount !== undefined && $ctrl.config.totalCount !== undefined" class="pf-table-view-selected-label"> | |||
| <strong>{{$ctrl.config.selectedCount}}</strong> of <strong>{{$ctrl.config.totalCount}}</strong> selected | |||
There was a problem hiding this comment.
Hi could you please add a unit test for this?
angular-patternfly/test/views/listview/list-view.spec.js
Thanks,
Dave
There was a problem hiding this comment.
@dtaylor113 would it make more sense to add the tests angular-patternflytest/filters/filter.spec.js? (sure as crap is easier 😆 )
There was a problem hiding this comment.
Sure, that would be fine. I just didn't see any 'selection' type tests in filter.spec, but there are some in list-view.spec. Whatever's easier is fine. -thanks
dtaylor113
approved these changes
Jun 7, 2017
jeff-phillips-18
approved these changes
Jun 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless selectedcount and total count are explicitly defined, will not display the "x of x selected" filter results text. Prevents unwanted text for instance, when there is no items to select
This changes behavior from being shown by default, to being shown when explicitly invoked, aligns closer with pf 3.x behavior
closes #480