Donut Chart: Fixed ngdoc example and added more unit tests #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -302,6 +310,29 @@ angular.module('patternfly.charts').directive('pfDonutPctChart', function (c3Cha | |||
| }; | |||
| }; | |||
|
|
|||
| $scope.getCenterLabelText = function (scope) { | |||
There was a problem hiding this comment.
No need to pass scope in here, use $scope inside the function
dtaylor113
force-pushed
the
master
branch
2 times, most recently
from
38acdb6 to
d34b39c
Compare
|
LGTM |
| @@ -611,6 +613,8 @@ angular.module('patternfly.card').directive('pfCard', function () { | |||
| 'total': '1000' | |||
| }; | |||
|
|
|||
| $scope.availLabel = "available"; | |||
There was a problem hiding this comment.
lol..'availLabel' is actually correct, consistent with 'usedLabel', 'pctLabel', and 'noLabel'.
jeff-phillips-18
added a commit
that referenced
this pull request
Sep 2, 2015
Donut Chart: Fixed ngdoc example and added more unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.