Skip to content

fix(pfFilter): Ensures complete alias support for select/complex-select #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2017
Merged

fix(pfFilter): Ensures complete alias support for select/complex-select #589

merged 1 commit into from
Aug 23, 2017

Conversation

AllenBW
Copy link
Contributor

@AllenBW AllenBW commented Aug 23, 2017 •
edited
Loading

Description

closes #583 (again, for good)

Last cut of this didn't have complete alias support, but check it, alias support EVERYWHERE (a user will ever see)

filter-alias

Also, single select is now by select type, rather than multiple categories
filter-alias2

PR Checklist

  • Unit tests are included
  • Screenshots are attached (if there are visual changes in the UI)
  • A Designer (@beanh66) is assigned as a reviewer (if there are visual changes in the UI)
  • A CSS rep (@cshinn) is assigned as a reviewer (if there are visual changes in the UI)

@AllenBW AllenBW added the bug label Aug 23, 2017
@AllenBW AllenBW mentioned this pull request Aug 23, 2017
Merged
@jeff-phillips-18 jeff-phillips-18 merged commit 4f9d6a6 into patternfly:master Aug 23, 2017
@AllenBW AllenBW deleted the enhancement/#583-filter-alias branch July 23, 2018 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-phillips-18 jeff-phillips-18 jeff-phillips-18 approved these changes

+1 more reviewer

@dtaylor113 dtaylor113 dtaylor113 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pfFilter support for filterAlias
3 participants
@AllenBW @jeff-phillips-18 @dtaylor113