fix(pfWizard): Make wizard buttons keyboard accessible #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtaylor113
approved these changes
Sep 12, 2017
|
Yeah, it's just changing the components to buttons, all classes and events stayed the same. |
| ng-class="{'wizard-pf-cancel-no-back': $ctrl.hideBackButton}" | ||
| ng-disabled="$ctrl.wizardDone" ng-click="$ctrl.onCancel()" | ||
| ng-if="!$ctrl.embedInPage">{{$ctrl.cancelTitle}}</pf-wiz-cancel> | ||
| <button ng-if="!$ctrl.embedInPage" |
There was a problem hiding this comment.
Looks good. My only question is, if there is a wizard with more than 2 panels, what happens when the "next" button is clicked? Does it reset focus on the first item in the next panel?
There was a problem hiding this comment.
This does not handle setting the focus when a page is shown. That would be left to the application. Barring the application setting the focus, the next button would still have the focus.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #603
Description
Changes the buttons in the pfWizard component to
<button>'s making them keyboard accessible. No longer using the pfWizardNext, pfWizardPrevious, or pfWizardCancel components.