Non-Breaking Unit Test Formatting Updates #660
Conversation
| $scope.nodes = {}; | ||
| for(var kind in nodeKinds) { | ||
|
|
||
| Object.keys(nodeKinds).forEach(function (kind) { |
There was a problem hiding this comment.
Altered this loop since it was linting towards something like.... Can alter it back towards this if we vote this direction
for(var kind in nodeKinds) {
if (nodeKinds.hasOwnProperty(kind)) {
...
There was a problem hiding this comment.
I don't have any particular preference. I'm fine with either.
cdcabrera
force-pushed
the
issue-lint
branch
3 times, most recently
from
8fdb855 to
b9a7430
Compare
cdcabrera
changed the title
| no-else-return: 2 | ||
| no-loop-func: 2 | ||
| vars-on-top: 2 | ||
| vars-on-top: 1 |
There was a problem hiding this comment.
This looks it's being relaxed. Was that intentional?
There was a problem hiding this comment.
Good catch, was unintentional but if we're good with it, which it sounds like we may be I can leave it be
| no-else-return: 2 | ||
| no-loop-func: 2 | ||
| vars-on-top: 2 | ||
| vars-on-top: 1 |
| var eUnFocused2 = page.find("#i2")[0]; | ||
|
|
||
| $scope.$apply(function(){ | ||
| $scope.$apply(function () { |
There was a problem hiding this comment.
I wouldn't mind removing this rule as well.
eslint.yaml
Outdated
| space-after-keywords: 2 | ||
| space-before-blocks: 2 | ||
| space-before-function-paren: 2 | ||
| space-before-function-paren: 1 |
There was a problem hiding this comment.
Relaxed this to a warning on the main, and turned it off for tests.
But we can go all the way with it @jeff-phillips-18 @dtaylor113 @amarie401 ?
There was a problem hiding this comment.
I say remove it completely.
eslint.yaml
Outdated
| vars-on-top: 1 | ||
| no-debugger: 2 | ||
| no-cond-assign: 2 | ||
| no-console: 2 |
There was a problem hiding this comment.
Can we change this to a 1? I'd like to see a warning about consoles, not an error.
Update code format for unit tests.
cdcabrera
dismissed stale reviews from amarie401 and jeff-phillips-18
via
7bdaa9b
Description
Related to PR #644 and issue #620
Closes #646
PR Checklist
Unit tests are includedScreenshots are attached (if there are visual changes in the UI)A Designer is assigned as a reviewer (if there are visual changes in the UI)A CSS rep is assigned as a reviewer (if there are visual changes in the UI)@beanh66