Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - v5 alpha testing - chart tooltip line spacing #9188

Closed
Tracked by #53
dlabrecq opened this issue May 25, 2023 · 1 comment · Fixed by #9276
Closed
Tracked by #53

Bug - v5 alpha testing - chart tooltip line spacing #9188

dlabrecq opened this issue May 25, 2023 · 1 comment · Fixed by #9276
Labels
bug PF5
Milestone
2023.08

Comments

@dlabrecq
Copy link
Member

While testing the HCS UI, I noticed that the tooltip line spacing is too large.

It's possible that the charts are not using the "pf-v5-c" prefix yet, but want to track this for now. Maybe we can check again with the next alpha update?

Before
Screenshot 2023-05-25 at 11 44 13 AM

After
Screenshot 2023-05-25 at 11 44 03 AM
@dlabrecq dlabrecq changed the title Bug - v5 alpha testing - pagination label wraps Bug - v5 alpha testing - chart tooltip line spacing May 25, 2023
@dlabrecq dlabrecq added the PF5 label Jun 2, 2023
@mcarrano mcarrano added this to the 2023.08 milestone Jun 6, 2023
@nicolethoen nicolethoen mentioned this issue Jun 6, 2023
Closed
11 tasks
@dlabrecq
Copy link
Member Author

dlabrecq commented Jun 8, 2023 •
edited

This appears to be an issue with Victory v36.6.10. I created the Victory issue below
https://github.com/FormidableLabs/victory/issues/2613

If Victory doesn't fix this fairly quickly, we should consider reverting back to v36.6.8.

In the mean time, apps can include version 36.6.8 as a package dependency to workaround the problem.

dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Jun 15, 2023
@dlabrecq
feat(charts): Update Victory packages to latest version
fab59bc 
patternfly#9188
@dlabrecq dlabrecq mentioned this issue Jun 15, 2023
Merged
tlabaj pushed a commit that referenced this issue Jun 15, 2023
@dlabrecq
feat(charts): Update Victory packages to latest version (#9276)
515b36f 
#9188
nicolethoen pushed a commit to Kells512/patternfly-react that referenced this issue Sep 1, 2023
@dlabrecq @nicolethoen
feat(charts): Update Victory packages to latest version (patternfly#9276
07f63c5 
)

patternfly#9188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug PF5
Projects
PatternFly Issues
Archived in project
Milestone
2023.08
Development

Successfully merging a pull request may close this issue.

feat(charts): Update Victory packages to latest version dlabrecq/patternfly-react
2 participants
@mcarrano @dlabrecq