feat(BreadcrumbSwitcher): creating a BreadcrumbSwitcher component

[glekner]

What:
creating a BreadcrumbSwitcher component

Additional issues:

[patternfly-build]

Deploy preview for patternfly-react-gone ready!

Built with commit e4e1b9f

https://deploy-preview-1109--patternfly-react-gone.netlify.com

[patternfly-build]

PatternFly-React preview: https://1109-pr-patternfly-react-patternfly.surge.sh

[coveralls]

Pull Request Test Coverage Report for Build 4230

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 80.196%

---

Totals
Change from base Build 4223:	0.0%
Covered Lines:	4624
Relevant Lines:	5416

---

💛 - Coveralls

[glekner]

@jeff-phillips-18 notice new dependencies.

[ohadlevy]

bump? :)

[jeff-phillips-18]

@patternfly/patternfly-react-ux

[serenamarie125]

@glekner can you explain what the arrow buttons are for here?

[serenamarie125]

@glekner can you address a few visual issues here?

1. colors used for hover and selected states seem to be reversed
2. the filter component should be wider - the left side of the filter component should be left aligned with the menu items
3. the left/right margins should match. right now, the long items bleeds into the margin

here's a screenshot of the design:

[serenamarie125]

i think the reference to where this came from should be removed from the storybook, thoughts on that @jeff-phillips-18 ?

[serenamarie125]

One more thing - our PF design doesn't have the "X" in it, although i think that's super helpful. Should it be selectable and enabled when nothing is in the text field ? Thoughts @maryclarke @lizsurette @Rohoover

[Rohoover]

Agreed - keep the "x". @serenamarie125

[glekner]

• Pagination is now optional
• Filter component is wider, long text won't overlap icons anymore
• Fixed margins

@serenamarie125 about the selected states, I believe once an option is selected the popover automatically closes and the user won't even see the colors. The hover colors are matching your screen shot?

[codecov-io]

Codecov Report

Merging #1109 into master will increase coverage by 0.03%.
The diff coverage is 87.23%.

@@            Coverage Diff             @@
##           master    #1109      +/-   ##
==========================================
+ Coverage   82.89%   82.92%   +0.03%     
==========================================
  Files         573      579       +6     
  Lines        6249     6296      +47     
  Branches       75       75              
==========================================
+ Hits         5180     5221      +41     
- Misses       1039     1045       +6     
  Partials       30       30

Flag	Coverage Δ
#patternfly3	84.78% <87.23%> (+0.03%)	⬆️
#patternfly4	79.58% <ø> (ø)	⬆️
#patternflymisc	95.68% <ø> (ø)	⬆️

Impacted Files	Coverage Δ
.../BreadcrumbSwitcher/BreadcrumbSwitcher.fixtures.js	100% <100%> (ø)
...dcrumbSwitcher/components/BreadcrumbSearchInput.js	100% <100%> (ø)
...nts/BreadcrumbSwitcher/BreadcrumbSwitcherHelper.js	100% <100%> (ø)
...mbSwitcher/components/BreadcrumbSwitcherToggler.js	100% <100%> (ø)
...omponents/BreadcrumbSwitcher/BreadcrumbSwitcher.js	72.72% <72.72%> (ø)
...mbSwitcher/components/BreadcrumbSwitcherPopover.js	83.33% <83.33%> (ø)
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a466069...d96a867. Read the comment docs.

[serenamarie125]

thanks for your contribution @glekner !

[glekner]

@jeff-phillips-18 @serenamarie125 added functionality test, I guess this pr is ready :)

[jeff-phillips-18]

@dlabaj Can you take another look?

[jeff-phillips-18]

@glekner Could you rebase please? I believe that should fix the test failure.

[glekner]

@jeff-phillips-18 rebased

[jeff-phillips-18]

@dlabaj @dgutride Can someone take a look please?

[glekner]

@jeff-phillips-18 added fixes from https://github.com/theforeman/foreman/pull/6382/files

[dlabaj]

LGTM