Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Radio): Modify examples and aria-label/label #1269

Merged
merged 1 commit into from
Jan 29, 2019
Merged

fix(Radio): Modify examples and aria-label/label #1269

merged 1 commit into from
Jan 29, 2019

Conversation

rebeccaalpert
Copy link
Member

@rebeccaalpert rebeccaalpert commented Jan 28, 2019

I removed the Custom Label Radio example, fixed the remaining examples so only one radio button can be selected at a time, and modified aria-labeling so that it's only present if there is no label.

I also updated the relevant snapshot.

Fixes #1007.

Removed Custom Label Radio, fixed examples so only one radio button can be selected at a time, and
modified aria-labeling so that it's only present if there is no label.
Also updated the relevant snapshot.

Fixes #1007
@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://1269-pr-patternfly-react-patternfly.surge.sh

@coveralls
Copy link

coveralls commented Jan 28, 2019

Pull Request Test Coverage Report for Build 4168

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 80.32%

Totals Coverage Status
Change from base Build 4156: 0.01%
Covered Lines: 4555
Relevant Lines: 5334

💛 - Coveralls

Copy link
Collaborator

@jgiardino jgiardino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates! I checked the behavior of label vs aria-label (i.e. by changing the label prop to aria-label in the code editor), and the html is updated as expected.

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@christiemolloy christiemolloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes Rebecca. My only concern is that the uncontrolled radio button is still being controlled by the user. The uncontrolled example in the switch component is not able to be controlled by the user, could you update this?

@tlabaj
Copy link
Contributor

tlabaj commented Jan 29, 2019

@christiemolloy Similar to the other PR #1270. I think the examples are fine as is and uncontrolled component should not be changed.

@tlabaj
Copy link
Contributor

tlabaj commented Jan 29, 2019

@christiemolloy @rebeccaalpert I opened an issue against the Switch component so it functions when uncontrolled. Good catch Christie!
#1275

@dlabaj dlabaj merged commit 168dcaf into patternfly:master Jan 29, 2019
@rebeccaalpert rebeccaalpert deleted the radio-audit-fixes branch January 29, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Radio Component Audit
7 participants