-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Radio): Modify examples and aria-label/label #1269
Conversation
Removed Custom Label Radio, fixed examples so only one radio button can be selected at a time, and modified aria-labeling so that it's only present if there is no label. Also updated the relevant snapshot. Fixes #1007
PatternFly-React preview: https://1269-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 4168
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these updates! I checked the behavior of label vs aria-label (i.e. by changing the label
prop to aria-label
in the code editor), and the html is updated as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these changes Rebecca. My only concern is that the uncontrolled radio button is still being controlled by the user. The uncontrolled example in the switch component is not able to be controlled by the user, could you update this?
@christiemolloy Similar to the other PR #1270. I think the examples are fine as is and uncontrolled component should not be changed. |
@christiemolloy @rebeccaalpert I opened an issue against the Switch component so it functions when uncontrolled. Good catch Christie! |
I removed the Custom Label Radio example, fixed the remaining examples so only one radio button can be selected at a time, and modified aria-labeling so that it's only present if there is no label.
I also updated the relevant snapshot.
Fixes #1007.