Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(AboutModal): Upgrade core to 1.0.175 and Refactor AboutModal #1307

Merged
merged 1 commit into from
Feb 1, 2019
Merged

refactor(AboutModal): Upgrade core to 1.0.175 and Refactor AboutModal #1307

merged 1 commit into from
Feb 1, 2019

Conversation

tlabaj
Copy link
Contributor

@tlabaj tlabaj commented Feb 1, 2019 •
edited
Loading

refactored AboutModal and removed heroImg and heroImageSrc and heroImageAlt props

#1267

What:

Additional issues:

@tlabaj
refactor(AboutModal): Upgrade core to 1.0.175 and Refactor AboutModal
e9f14b4 
BREAKING CHANGE: removed heroImg and heroImageSrc and heroImageAlt props

patternfly#1267
@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://1307-pr-patternfly-react-patternfly.surge.sh

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4259

  • 4 of 5 (80.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.225%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/patternfly-4/react-core/src/components/AboutModal/AboutModalContainer.js 0 1 0.0%
Totals Coverage Status
Change from base Build 4257: 0.0%
Covered Lines: 4632
Relevant Lines: 5424
💛 - Coveralls

@dlabaj dlabaj merged commit 1f85756 into patternfly:master Feb 1, 2019
@tlabaj tlabaj mentioned this pull request Feb 4, 2019
Closed
dgutride pushed a commit to dgutride/patternfly-react that referenced this pull request Feb 6, 2019
@tlabaj @dgutride
refactor(AboutModal): Upgrade core to 1.0.175 and Refactor AboutModal (…
4a1401d 
…patternfly#1307)

removed heroImg and heroImageSrc and heroImageAlt props
@rhamilto
Copy link
Member

With the removal of heroImageSrc, what's the recommended solution for Webpack? As it stands, Webpack does not bundle images from patternfly-core. cc: @jeff-phillips-18

@jeff-phillips-18
Copy link
Member

@tlabaj what is the intent here? How do application set the heroImageSrc now?

@rhamilto rhamilto mentioned this pull request Feb 28, 2019
Merged
@tlabaj
Copy link
Contributor Author

tlabaj commented Mar 1, 2019

@jeff-phillips-18 The heroImage is being set by css now.

@ryelo ryelo mentioned this pull request Apr 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgutride dgutride dgutride approved these changes

@dlabaj dlabaj dlabaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tlabaj @patternfly-build @coveralls @rhamilto @jeff-phillips-18 @dlabaj @dgutride