Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): Use direct imports for styles #1314

Merged
merged 1 commit into from
Feb 4, 2019

Conversation

karelhala
Copy link
Contributor

@karelhala karelhala commented Feb 4, 2019

What:
Re-adds changes made in this PR #1237 because they were removed in #1304

Additional issues:

@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://1314-pr-patternfly-react-patternfly.surge.sh

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4270

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 80.213%

Totals Coverage Status
Change from base Build 4260: -0.01%
Covered Lines: 4631
Relevant Lines: 5423

💛 - Coveralls

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit 42b20e6 into patternfly:master Feb 4, 2019
@martinpovolny
Copy link
Contributor

I wonder if you are testing the latest patternfy with the insights-chrome?

Each time I upgrade PF I spend several hours figuring what versions work together.

My understanding is that the Insights is the main user of PF4 for now. So it would make sense to me to test the 2 together.

dgutride pushed a commit to dgutride/patternfly-react that referenced this pull request Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants