Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(EmptyState): add example to set icon size #1436

Closed
wants to merge 1 commit into from
Closed

docs(EmptyState): add example to set icon size #1436

wants to merge 1 commit into from

Conversation

boaz0
Copy link
Member

@boaz0 boaz0 commented Feb 24, 2019

What:

closes #1434

Added an example of how to set the icon size through EmptyStateIcon.

In general, EmptyStateIcon also has color and title props that set the icon color and title.

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@tlabaj
Copy link
Contributor

tlabaj commented Feb 25, 2019

@christiemolloy We don't have an example in core that matches this. Is it worth adding? Or maybe we If so, I can add an issue in core. The example is useful for the consumer.

@tlabaj
Copy link
Contributor

tlabaj commented Feb 25, 2019

@redallen This one did not deploy a preview.

@redallen
Copy link
Contributor

CircleCI is pretty inconsistent building the Patternfly-4 docs, it's on my backlog of things to look into. In the future, just click "Rerun workflow" in CircleCI (I just kicked it off again for you).

@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://1436-pr-patternfly-react-patternfly.surge.sh

Copy link
Member

@christiemolloy christiemolloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the example with the extra large icon should be removed because that icon size goes beyond the variables we currently have for icon sizing. I think an icon this large would be a question for design? and maybe its more of an image? I'll talk with design and get back to you.

UPDATE:
Checked with design and the icon size for empty state should always be 54px. So you can remove the example.

@tlabaj
Copy link
Contributor

tlabaj commented Feb 25, 2019

@christiemolloy Thanks for the feedback!

@tlabaj
Copy link
Contributor

tlabaj commented Feb 25, 2019

Closing this PR since the example is not consistent with core and the Empty state Icon should not be resized.

@tlabaj tlabaj closed this Feb 25, 2019
@boaz0 boaz0 deleted the icon_size_emptystate_example branch April 24, 2020 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PF4 Empty State Icon: Allow size to be set
5 participants