fix(TimePicker): resolved border styling on open menu #9214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-9214.surge.sh A11y report: https://patternfly-react-pr-9214-a11y.surge.sh |
srambach
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
This looks ok to me. @mcoker's patternfly/patternfly#5641 might affect the focus ring/status underline because this is using form-control.
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
nicolethoen
pushed a commit
to Kells512/patternfly-react
that referenced
this pull request
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9156
Timepicker preview
Issue seemed to be still pointing to the inputRef, which was no longer viable after we updated the markup for form control components to include a wrapper div.
Additional issues: