Add OpenShift MultiContentCard (GettingStarted) #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolethoen
reviewed
Feb 19, 2024
| </Card>, | ||
| <Card isFullHeight isPlain key="card-2"> | ||
| <CardBody className="pf-v5-u-display-flex pf-v5-u-pt-3xl-on-md"> | ||
| <TextContent className="pf-v5-u-display-flex pf-v5-u-flex-direction-column pf-v5-u-align-self-stretch"> |
There was a problem hiding this comment.
I think all theses utility classes can be replaced by a Flex layout with modifiers for direction={{ default: 'column' }} and use the various spacing features :https://www.patternfly.org/layouts/flex#spacing to match this demo: https://www.patternfly.org/patterns/dashboard/html-demos/basic/
nicolethoen
reviewed
Feb 19, 2024
| } | ||
| } | ||
| }, | ||
| multiContentCardBorder: { |
There was a problem hiding this comment.
Let's use Divider components rather than borders
|
Thanks @nicolethoen for taking a look, working on the updates.. |
nicolethoen
reviewed
Feb 28, 2024
| </TextContent> | ||
| </CardHeader> | ||
| <CardBody className="pf-v5-u-display-flex"> | ||
| <TextContent className="pf-v5-u-display-flex pf-v5-u-flex-direction-column pf-v5-u-align-self-stretch"> |
There was a problem hiding this comment.
I believe a Flex layout could be used in place of all these utility classes
nicolethoen
reviewed
Feb 28, 2024
nicolethoen
approved these changes
Feb 29, 2024
|
🎉 This PR is included in version 5.1.0-prerelease.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #97
RHCLOUD-30683
Added a new MultiContentCard component to replace OpenShift and HCC implementations.