Skip to content

feat: Add Maintenance component #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 1, 2024
Merged

Conversation

aferd
Copy link
Collaborator

@aferd aferd commented Oct 25, 2024

RHCLOUD-33366 Add Maintenance component

@patternfly-build
Copy link

patternfly-build commented Oct 25, 2024

@aferd aferd requested a review from fhlavac October 25, 2024 18:32
@fhlavac
Copy link
Collaborator

fhlavac commented Oct 29, 2024

@aferd it looks really good, just two thoughts on props that may allow more customizability in case it's needed

Can you please also improve the commit messages to trigger the semantic release when merged? Thank you

@aferd aferd changed the title RHCLOUD-33366 Add Maintenance component feat: Add Maintenance component Oct 29, 2024
Copy link
Collaborator

@karelhala karelhala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just one minor question.

@aferd aferd requested a review from fhlavac October 31, 2024 15:58
@aferd aferd merged commit d051d18 into patternfly:main Nov 1, 2024
6 checks passed
Copy link

github-actions bot commented Nov 1, 2024

🎉 This PR is included in version 6.1.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants