Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions packages/module/src/Hooks/filters.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,33 @@ describe('useDataViewFilters', () => {
expect(setSearchParams).toHaveBeenCalled();
});

it('should sync with URL search params with non array value', () => {
const searchParams = new URLSearchParams();
searchParams.set('test', 'foo');
const setSearchParams = jest.fn();
const props: UseDataViewFiltersProps<{ test: string }> = {
initialFilters: { test: '' },
searchParams,
setSearchParams,
};
const { result } = renderHook(() => useDataViewFilters(props));
expect(result.current.filters).toEqual({ test: 'foo' });
})
it('should sync with URL search params with array value', () => {

const searchParams = new URLSearchParams();
searchParams.append('test', 'foo');
searchParams.append('test', 'bar');
const setSearchParams = jest.fn();
const props: UseDataViewFiltersProps<{ test: string[] }> = {
initialFilters: { test: [] },
searchParams,
setSearchParams,
};
const { result } = renderHook(() => useDataViewFilters(props));
expect(result.current.filters).toEqual({ test: [ 'foo', 'bar' ] });
})

it('should reset filters to default values when clearAllFilters is called', () => {
const { result } = renderHook(() => useDataViewFilters({ initialFilters }));
act(() => result.current.clearAllFilters());
Expand Down
2 changes: 1 addition & 1 deletion packages/module/src/Hooks/filters.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ export const useDataViewFilters = <T extends object>({

const getInitialFilters = useCallback((): T => isUrlSyncEnabled
? Object.keys(initialFilters).reduce((loadedFilters, key) => {
const urlValue = searchParams?.get(key);
const isArrayFilter = Array.isArray(initialFilters[key]);
const urlValue = isArrayFilter ? searchParams?.getAll(key) : searchParams?.get(key);

// eslint-disable-next-line no-nested-ternary
loadedFilters[key] = urlValue
Expand Down
Loading