Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-saving criteria is broken #943

Closed
rubenarslan opened this issue Jul 2, 2020 · 2 comments
Closed

auto-saving criteria is broken #943

rubenarslan opened this issue Jul 2, 2020 · 2 comments
Labels
Milestone

Comments

@rubenarslan
Copy link

I think you changed the structure of the brmsfit object, but forgot to change it in one place in add_criterion. You used to store it in x$loo etc. Now, it is
x$criteria$loo.

But this line still checks x$loo.

brms/R/loo.R

Line 508 in 70265e8

new_criteria <- criterion[ulapply(x[criterion], is.null)]

I guess it should be

new_criteria <- criterion[ulapply(x$criteria[criterion], is.null)]
@paul-buerkner
Copy link
Owner

You are right, thank you! Will fix it asap.

@paul-buerkner
Copy link
Owner

Thanks! Should now be fixed.

paul-buerkner added a commit that referenced this issue Jul 2, 2020
@paul-buerkner paul-buerkner added this to the brms 2.13.0++ milestone Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants