Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme.md - add windows passing and linux passing to CI badges. #263

Merged
merged 1 commit into from
Mar 22, 2015

Conversation

shakyShane
Copy link
Contributor

Given that this lib has gone to great efforts to ensure full support for both Windows + Unix-like systems, I believe that it should be clearer to users that this is the case.

Unless they are using app veyor themselves, the vast majority of your users will be none the wiser in regards to OS support as the app veyor logo will mean nothing to them.

This change is a simple one, but will make it crystal clear to all users that you take Windows support seriously.

Preview:

http://f.cl.ly/items/2U151G0q3q2H0B3v253n/Screen%20Shot%202015-03-22%20at%2015.58.41.png

@es128
Copy link
Contributor

es128 commented Mar 22, 2015

Thanks for the PR and the supportive comments. For this lib, Mac is actually a totally distinct case from Linux as well. Any idea how to distinguish between them from the Travis tests for separate badges on those?

@shakyShane
Copy link
Contributor Author

Badges on travis are per-build - so you couldn't have separate badges.

Nothing stopping something like ...

travis

... though :)

@shakyShane
Copy link
Contributor Author

or even this looks nicer I think

https://img.shields.io/travis/paulmillr/chokidar/master.svg?label=Mac%20OSX%20%26%20Linux

travis

@shakyShane
Copy link
Contributor Author

Updated, preview https://github.com/shakyShane/chokidar

@es128
Copy link
Contributor

es128 commented Mar 22, 2015

Yup, looks great. Thanks.

es128 added a commit that referenced this pull request Mar 22, 2015
Readme.md - add `windows passing` and `linux passing` to CI badges.
@es128 es128 merged commit 165273f into paulmillr:master Mar 22, 2015
@shakyShane
Copy link
Contributor Author

👍 - thanks to you for the great lib - I'm in the process of using it to replace Gaze in BrowserSync :)

@es128
Copy link
Contributor

es128 commented Mar 22, 2015

Cool. Let me know when that's published and we can mention it in the chokidar readme.

@shakyShane
Copy link
Contributor Author

Will do, reliant on #264 however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants