Handle awf unlink and polling race condition #394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpusch
changed the title
| cancelWait: function() { | ||
| delete this._pendingWrites[path]; | ||
| clearTimeout(timeoutHandler); | ||
| return callback(); |
There was a problem hiding this comment.
So that the pending function will be invoked. I know it won't do anything since err and stat are null, but I still think we should not allow it to just hang there
|
I like this change, but the inconsistency about treating the emitting function like an async-flow-pattern callback remain. I refactored a bit further in https://github.com/paulmillr/chokidar/tree/alexpusch-awf-fix-refactor in an attempt to make it clearer (to avoid confusion that if callback isn't called it would disrupt the necessary control flow) |
|
Looks great, change in terminology achieved exactly what you said. I'll update my PR |
|
No need. Your commit is already there. Will just merge the branch to master. Thanks for your help with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.