bump is-glob #631
Closed
bump is-glob #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i think i did smth wrong while creating pr since the commits from the last one displaying as well 😕 |
1 similar comment
|
@MhMadHamster yeah it's because I used the "Squash and merge" button for your last PR, so if you kept your same branch going it's going to have a diverged commit history. But if I do the same thing with this one it probably won't end up mattering. |
|
i'm not certainly sure in the correctness of current "fix", this needs more investigation |
|
Макс, красава, весь хотелс за тебя кулочки держит! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bump is-glob version should fix some issues with parentheses, (!) [] etc in path, some tests for such cases need to be added probably