[MERGED] Re-enable warning 239 for native functions #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8948f20.
Daniel-Cortez
changed the title
Southclaws
approved these changes
Jul 26, 2019
Closed
Y-Less
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A year ago warning 239 was disabled for native functions because of SA-MP functions being defined in an incorrect way.
As it was recently highlighted in another conversation, now we have the modified includes that fix the const-correctness issue, so we can remove that restriction from warning 239.
Which issue(s) this PR fixes:
What kind of pull this is:
Additional Documentation: