suppress warning; URI.escape is obsolete #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 3, 2017
|
@takahashim プルリクエストありがとうございます。たいへん参考になりました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PAY.jpのRubyライブラリを評価しているのですが、テストを実行するとwarningがたくさん出るようなので、消す修正のpull requestをお送りします（3件に分けて送ります）。
まず、URI.escapeのwarningが多発しているようですが、
Payjp::Util.url_encodeの変換はCGI.escapeやURI.encode_www_form_componentなどの変換とは異なるようなので、URI::RFC2396_Parser#escapeの部分を利用しています。念のため、1バイトの範囲内では挙動が適切であるのが確認できるよう、テストを追加しておきました。
ご検討ください。