Change default field names in Form Builder plugin to avoid naming conflicts

[MurzNN]

Describe the Bug

If I add the Form Builder Plugin to a Payload project that uses collections with some popular names like Countries, States, Texts, Messages, etc, it starts to throw an error when building the GraphQL schema like this:

Error: Schema must contain uniquely named types but contains multiple types named "Text".
    at new Promise (<anonymous>)
 POST /api/graphql 500 in 1844ms

I spent hours on debugging to find the real source of this error, and the reason was the Form Builder Plugin!

This issue is even mentioned in the documentation https://payloadcms.com/docs/plugins/form-builder#preventing-generated-schema-naming-conflicts even with a suggested workaround!

But how many developers do actually read the documentation, right? 😜

So, instead of suggesting a workaround, I think it's a good idea to fix the source of the issue, and name the Form Builder Plugin block types with the appropriate suffix by default:

• country » countryFormField
  etc.

This renaming should also make the name of the GraphQL type clearer and self-describable.

P.S. Here is the list of all "restricted" collection names:

    checkbox?: boolean | FieldConfig;
    country?: boolean | FieldConfig;
    date?: boolean | FieldConfig;
    email?: boolean | FieldConfig;
    message?: boolean | FieldConfig;
    number?: boolean | FieldConfig;
    payment?: boolean | FieldConfig;
    select?: boolean | FieldConfig;
    state?: boolean | FieldConfig;
    text?: boolean | FieldConfig;
    textarea?: boolean | FieldConfig;

Link to the code that reproduces this issue

https://github.com/Murz-forks/pl-fb-issue-1

Reproduction Steps

1. Install the Form Builder Plugin example.
2. Add the Texts collection to the project.
3. Open the GraphQL playground.
4. See the 500 error in the console:

Error: Schema must contain uniquely named types but contains multiple types named "Text".

Which area(s) are affected?

plugin: form-builder

Environment Info

Any environment

[MurzNN]

And, if we have the same issue with too generic naming of the types in other plugins too, would be great to make the more specific names there too.

[paulpopus]

I totally get where you're coming from but this would be a breaking change, quite a severe one at that, so it's only something we may be able to do in v4 and as such I've marked it as a request

[MurzNN]

How can we mark this feature request for inclusion in the list of feature requests for Payload v4, so we don't lose it?