fix(templates): uri encode the cacheTag in getMediaUrl utility - Website template #13558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yazalulloa
changed the title
paulpopus
requested changes
Sep 2, 2025
There was a problem hiding this comment.
These changes should actually be in this file templates/website/src/utilities/getMediaUrl.ts
Could you make that change please? encodeURIComponent(cacheTag) in both places there where the cacheTag is being used.
This would cover other use cases and allow the util to take care of encoding.
Also copy this over to the vercel- version of the template.
|
I added the changes |
paulpopus
approved these changes
Sep 4, 2025
|
Thank you! Will get this merged once CI passes |
paulpopus
changed the title
paulpopus
changed the title
|
🚀 This is included in version v3.55.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Encode the cacheTag in the ImageMedia component
Why?
In the website template, media is render using the updatedAt field as a cacheTag, this value causes an InvalidQueryStringException when deploying to Cloudfront
How?
Uses encodeURIComponent on encode the date value of updatedAt
Fixes #13557