Fix issue 116: Functional updates broken when value needs to be encoded #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for this, can you please add tests to useQueryParam and useQueryParams that break before this change and pass after it? |
…ed - including test
|
Hey Peter, I added a test to the relevant test cases; they fail using the current branch (expect something else than the returned 'null') and succeed with my change. |
|
Thank you! Fixes #116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Values returned from an update function are not encoded; types not allowed by history.push({query}) are not reflected in the URL and hence they are lost.
The fix is to encode them, just like direct updates.