Fix multiple updates in a single render in tests (modified) #86

pbeshai · 2020-04-17T02:46:04Z

Adjusts Fix multiple updates in a single render in tests #84 to work with recent changes
Resolves Concurrent updates fail with mocked and in-memory histories #62 (see Fix multiple updates in a single render in tests #84 for reasoning)

This reverts commit dc46057.

…ner/use-query-params into dprgarner-62-fix-concurrent-updates # Conflicts: # src/__tests__/updateUrlQuery-test.ts # src/__tests__/useQueryParams-test.tsx # src/updateUrlQuery.ts # src/useQueryParam.ts # src/useQueryParams.ts

dprgarner and others added 8 commits April 16, 2020 19:29

Revert "Fix concurent updates when using React Router. fixes #54"

ae13a0f

This reverts commit dc46057.

Update location ref when setting params

4891942

Only provide location and setters via context

4af0c52

Use simpler callback; extract out context module; check location exists.

9269e15

Fix docs to stay up-to-date with docstrings

d62aa2f

Add back in dev check for QueryParamProvider

8f7cc87

Update to latest serialize query params with correct types

0c61c0d

pbeshai mentioned this pull request Apr 17, 2020

Fix multiple updates in a single render in tests #84

Closed

pbeshai added 4 commits April 16, 2020 20:35

Rename getLocation to createLocationWithChanges

c8a11b8

Rename getLocation to createLocationWithChanges

c3132f7

Add caching for adapted histories, examples of #46

de61929

Add caching of adapted histories

c470a71

pbeshai merged commit 19c112b into master Apr 17, 2020

pbeshai deleted the dprgarner-62-fix-concurrent-updates branch April 17, 2020 03:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix multiple updates in a single render in tests (modified) #86

Fix multiple updates in a single render in tests (modified) #86

Uh oh!

pbeshai commented Apr 17, 2020 •

edited

Loading

Uh oh!

Uh oh!

Fix multiple updates in a single render in tests (modified) #86

Fix multiple updates in a single render in tests (modified) #86

Uh oh!

Conversation

pbeshai commented Apr 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

pbeshai commented Apr 17, 2020 •

edited

Loading