Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

percent_encoding becomes private in url>=2.0.0 #12

Closed
pchampin opened this issue Aug 6, 2019 · 1 comment · Fixed by #13
Closed

percent_encoding becomes private in url>=2.0.0 #12

pchampin opened this issue Aug 6, 2019 · 1 comment · Fixed by #13

Comments

@pchampin
Copy link
Owner

pchampin commented Aug 6, 2019

...and the XML parser uses it, which prevents us from upgrading the dependency to url beyond 1.7.2. @althanos, could you please have look at it and see if we can get rid of this? Thanks in advance...
@althonos
Copy link
Contributor

althonos commented Aug 6, 2019

I don't think we need to use the exact same version as the url crate, so this could be resolved
simply by adding percent-encoding as a dependency. PR on the way.

@althonos althonos mentioned this issue Aug 6, 2019
Merged
pchampin added a commit that referenced this issue Aug 7, 2019
@pchampin
updated dependencies
69bf346 
except for url (see issue #12)
pchampin added a commit that referenced this issue Aug 7, 2019
@pchampin
Merge remote-tracking branch 'althonos/master' (PR #13)
26fdb43 
- fix #12
- ensures that optional features appear on doc.rs

This one made it to the release at the very last minute :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix XML parser and bump URL dependency
2 participants
@pchampin @althonos