-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Handle import of distutils for python 3.12 #438
Conversation
if sys.version_info >= (3, 11): | ||
from sysconfig import get_path | ||
libdir = get_path("platlib") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like sysconfig is a module all since Python 3.2 ... Maybe we can just skip the if
?
None of this code will work anyway — the code is looking for (Of course, so will most other packages installed in the venv, so it's necessary to look for a |
IIUC correctly, based on the comment above the code that uses Honestly, the most sensible solution, to me, seems to be: Just don't support that. It's a lot of effort for very little reward. When working in a venv, install Otherwise, checking for a But if And if So I really don't get what that code is trying to do anyway. |
@ferdnyc Apparenly, this being a non-issue hasn't always been the case ... 🤷 |
This PR adds code to handle the import of the
sysconfig
module for Python >= 3.11