Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for ISSUE-564 #565

Closed
wants to merge 1 commit into from
Closed

Fix for ISSUE-564 #565

wants to merge 1 commit into from

Conversation

monobaila
Copy link

  • Ensure "fail fast" during sync if any AWS Errors come back, if we don't have accurate list ouputs from source/dest it's safer to bail over treating them as empty.
  • Add E2E test, currently for failing fast if target bucket doesn't exist. I'm not able to add a test for original failure case in bug report as mock framework doesn't seem to support this?

@monobaila monobaila requested a review from a team as a code owner May 7, 2023 14:33
@monobaila monobaila requested review from igungor and sonmezonur and removed request for a team May 7, 2023 14:33
@monobaila monobaila mentioned this pull request May 7, 2023
Closed
@monobaila
Fix for ISSUE-564
61f6dda 
* Ensure "fail fast" during sync if any AWS Errors come back, if
  we don't have accurate list ouputs from source/dest it's safer
  to bail over treating them as empty.
* Add E2E test, currently for failing fast if target bucket doesn't
  exist. I'm not able to add a test for original failure case in bug
  report as mock framework doesn't seem to support this?
@ahmethakanbesel
Copy link
Contributor

Hi monabaila,

Thank you for your interest in s5cmd and your contribution to resolving this issue. The issue has been fixed in version 2.2.0. We have decided to take a different approach to the problem, rather than checking for errors at the end of the listing process.

You are correct that the mock s3 server used in the tests does not support bucket policies. As a result, we can only test for the NoSuchBucket error.

Please let me know if you have any other questions.

@igungor
Copy link
Member

igungor commented Sep 13, 2023

Thank you for the PR @monobaila. As @ahmethakanbesel explained above, the issue is fixed with #597. I'm closing your PR.

@igungor igungor closed this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igungor igungor Awaiting requested review from igungor igungor is a code owner automatically assigned from peak/big-data

@sonmezonur sonmezonur Awaiting requested review from sonmezonur sonmezonur is a code owner automatically assigned from peak/big-data

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@monobaila @ahmethakanbesel @igungor