Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
examples
andexamples_security
submodules, removing the only external dependency. I wasn't sure about movingexamples_security
toexamples/security
, but I can update the PR if you think that would make more sense.This PR depends on an unreleased version zmq4 1.3.0
Unfortunately it seems the best way to convert a subpackage into a module is to depend on a future version where that subpackage doesn't exist; the naïve solution leads to build failures. You can add
replace github.com/pebbe/zmq4 v1.3.0 => ../
togo.mod
if you want to test the changes.See https://github.com/golang/go/wiki/Modules#is-it-possible-to-add-a-module-to-a-multi-module-repository